feat(cli): add promptless args to README.md#864
Conversation
🦋 Changeset detectedLatest commit: 669aaf1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Looks like the tests are failing. You can easily reproduce this by running Apart from that I will leave this open for @jycouet so that he can check if and how this will conflict with the changes from #684 |
|
There are still failing tests, but I'm going to leave it as is until @jycouet gives it a pass, as this may be the wrong approach. |
jycouet
left a comment
jycouet
left a comment
There was a problem hiding this comment.
Tests are failing on windows because of / or \
The issue is more deep than just the args stuff. it's the [path] that should use something like path.posix
I just tested on windows and npx sv create hello/you is working. So we should make it / in all OS imo.
packages/sv/lib/cli/add/index.ts
Outdated
| if (fromCommand === 'add') common.logArgs(packageManager, 'add', argsFormattedAddons); | ||
| if (fromCommand === 'add') { | ||
| const prompt = common.buildArgs(packageManager, 'add', argsFormattedAddons); | ||
| p.log.message(`To rerun this command without prompts, run:\n${pc.dim(prompt)}`); |
There was a problem hiding this comment.
Look at the other comment for location.
Having a small text on top, why not... But very small imo. (I did a few when the feature was crafted, but didn't find something nice)
There was a problem hiding this comment.
What about:
- To re-run without prompts:
- Reproducible CLI command:
- Non-interactive:
- Automate with:
- Skip prompts:
- Run again:
There was a problem hiding this comment.
- Re-run without questions
- Re-run without prompts
- Run again, no questions asked
- Run again, no prompts
I this that the text should by gray, maybe try with log info as well to have a dot in timeline ? (I think I didn't like it much, but with a title maybe... Maybe not 😅
This reverts commit fef505e.
|
Right now, it's with the blue dot in the timeline, I tried other style to see: Yeah, the blu is probably the best 👍 I'll update a few thing in the code s00n before merging |
jycouet
left a comment
jycouet
left a comment
There was a problem hiding this comment.
The readme is not updated when we do just a add cmd in a second step. It's probably "normal", but I would like to note it here.
3 participants
closes #863
I cannot reuse the process built into
createKitto updateREADME.mdas the order of operation iscreateKit->runAddonsApply->buildArgs, at that point it is too late to usecreateKit. Thus, a manual approach was used to update theREADME.md.